Skip to content

Refactor AudioTrackDialog for improved localization and user experience #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Refactor AudioTrackDialog for improved localization and user experience #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/ReaderScreen/components/AudioPlayer/components/AudioTrackDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,17 @@ const AudioTrackDialog = ({
/>
) : (
<View style={styles.noTracksContainer}>
<CustomText style={styles.noTracksText}>Maafi ji 🙏🏽</CustomText>
<CustomText style={styles.noTracksText}>{STRINGS.MAAFI_JI}</CustomText>
<CustomText style={styles.noTracksSubtext}>
We do not have audios for{" "}
{STRINGS.WE_DO_NOT_HAVE_AUDIOS_FOR}{" "}
<CustomText
style={{
fontFamily: fontFace,
}}
>
{title}
</CustomText>{" "}
yet.
{STRINGS.YET}.
</CustomText>
<Pressable
style={styles.joinMailingListButton}
Expand All @@ -105,7 +105,9 @@ const AudioTrackDialog = ({
})
}
>
<CustomText style={styles.joinMailingListText}>Request audio for this paath.</CustomText>
<CustomText style={styles.joinMailingListText}>
{STRINGS.REQUST_AUDIO_FOR_THIS_PAATH}
</CustomText>
</Pressable>
</View>
);
Expand Down
24 changes: 24 additions & 0 deletions src/common/localization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ const STRINGS = new LocalizedStrings({
NETWORK_ERROR: "Network error. Audio features temporarily unavailable.",
COULD_NOT_LOAD_AUDIO_ARTISTS: "Could not load audio artists. Please check your connection.",
PERMISSION_ERROR: "Broadcast permission check failed — missing or denied permission",
MAAFI_JI: "Maafi ji 🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "We do not have audios for",
REQUEST_AUDIO_FOR_THIS_PAATH: "Request audio for this paath.",
YET: "yet.",
},
hi: {
about: "हमारे बारे",
Expand Down Expand Up @@ -329,6 +333,10 @@ const STRINGS = new LocalizedStrings({
COULD_NOT_LOAD_AUDIO_ARTISTS:
"ऑडियो कलाकारों को लोड करने में असमर्थ। कृपया अपना कनेक्शन जांचें।",
PERMISSION_ERROR: "प्रसारण अनुमति जाँच विफल - अनुमति अनुपलब्ध या अस्वीकृत",
MAAFI_JI: "क्षमा करें जी 🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "हमारे पास ऑडियो नहीं है",
REQUEST_AUDIO_FOR_THIS_PAATH: "इस पाठ के लिए ऑडियो का अनुरोध करें",
YET: "अभी तक।",
},

pa: {
Expand Down Expand Up @@ -494,6 +502,10 @@ const STRINGS = new LocalizedStrings({
COULD_NOT_LOAD_AUDIO_ARTISTS:
"ਆਡੀਓ ਕਲਾਕਾਰਾਂ ਨੂੰ ਲੋਡ ਕਰਨ ਲਈ ਅਸਮਰਥ। ਕਿਰਪਾ ਕਰਕੇ ਆਪਣਾ ਕਨੈਕਸ਼ਨ ਜਾਂਚੋ।",
PERMISSION_ERROR: "ਪ੍ਰਸਾਰਣ ਇਜਾਜ਼ਤ ਜਾਂਚ ਅਸਫਲ ਰਹੀ — ਇਜਾਜ਼ਤ ਗੁੰਮ ਹੈ ਜਾਂ ਅਸਵੀਕਾਰ ਕੀਤੀ ਗਈ ਹੈ",
MAAFI_JI: "ਮਾਫ਼ ਕਰਨਾ ਜੀ 🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "ਸਾਡੇ ਕੋਲ ਇਹਨਾਂ ਲਈ ਆਡੀਓ ਨਹੀਂ ਹਨ",
REQUEST_AUDIO_FOR_THIS_PAATH: "ਇਸ ਪਾਠ ਲਈ ਆਡੀਓ ਦੀ ਬੇਨਤੀ ਕਰੋ।",
YET: "",
Copy link

@Gauravjeetsingh Gauravjeetsingh Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the translation for YET

},
fr: {
about: "Infos",
Expand Down Expand Up @@ -666,6 +678,10 @@ const STRINGS = new LocalizedStrings({
"Impossible de charger les artistes audio. Veuillez vérifier votre connexion.",
PERMISSION_ERROR:
"Échec de la vérification de l'autorisation de diffusion : autorisation manquante ou refusée",
MAAFI_JI: "Désolé JI🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "Nous n'avons pas d'audios pour",
REQUEST_AUDIO_FOR_THIS_PAATH: "Demander un audio pour ce chemin.",
YET: "encore.",
},
it: {
about: "Info",
Expand Down Expand Up @@ -829,6 +845,10 @@ const STRINGS = new LocalizedStrings({
"No se pueden cargar los artistas de audio. Por favor, verifique su conexión.",
PERMISSION_ERROR:
"Controllo dell'autorizzazione di trasmissione non riuscito: autorizzazione mancante o negata",
MAAFI_JI: "Mi dispiace Ji🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "Non abbiamo audio per",
REQUEST_AUDIO_FOR_THIS_PAATH: "Richiedi audio per questo percorso.",
YET: "ancora.",
},
es: {
about: "Sobre Nosotros",
Expand Down Expand Up @@ -1000,6 +1020,10 @@ const STRINGS = new LocalizedStrings({
NETWORK_ERROR: "Error de red. Las funciones de audio están temporalmente indisponibles.",
COULD_NOT_LOAD_AUDIO_ARTISTS:
"No se pueden cargar los artistas de audio. Por favor, verifique su conexión.",
MAAFI_JI: "Lo siento Ji🙏🏽",
WE_DO_NOT_HAVE_AUDIOS_FOR: "No tenemos audios para",
REQUEST_AUDIO_FOR_THIS_PAATH: "Solicitar audio para esta ruta.",
YET: "aún.",
});

export default STRINGS;