Refactor components and enhance BottomNavigation integration #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated StatusBarComponent background color in multiple components for visual consistency. - Integrated BottomNavigation into HomeScreen, Bookmarks, ReaderScreen, and Settings for improved navigation. - Simplified BaniHeader component by removing unused props and imports. - Enhanced BottomNavigation functionality to dynamically handle navigation based on current state. - Added localization strings for new navigation items to support multiple languages.
- Updated the icon size in the BottomNavigation component to a fixed value of 24 for consistency, removing conditional logic based on active key.
…ponents - Removed hardcoded navigation items from Bookmarks component and updated BottomNavigation to directly use the navigation prop for improved flexibility. - Cleaned up imports and streamlined code in HomeScreen by removing the BottomNavigation component, enhancing overall maintainability.
- Implemented handleBookmarkPress function to navigate to the bookmarks screen when the bookmark button is pressed. - Updated ReaderScreen to utilize the new bookmark handler, enhancing user navigation experience.
- Added localization strings for navigation items in BottomNavigation, improving accessibility and user experience. - Updated the rendering of navigation item text to utilize localized strings instead of hardcoded values.
- Removed unused audio toggle functionality to streamline the component. - Adjusted audio playback speed validation to allow a range from 0.5 to 2.0 for better user control. - Updated the disabled state for speed adjustment buttons to reflect the new playback speed limits.
Gauravjeetsingh
suggested changes
Nov 6, 2025
src/common/localization.js
Outdated
| DOWNLOADING: "ਡਾਊਨਲੋਡ ਹੋ ਰਹਿ ਰਹਾ ਹੈ", | ||
| NEXT: "ਅਗਲਾ", | ||
| HOME: "ਹੋਮ", | ||
| READ: "ਰੀਡ", |
There was a problem hiding this comment.
The translation of read is wrong here.
src/common/icons/ReadIcon.jsx
Outdated
| export default ReadIcon; | ||
|
|
||
| ReadIcon.propTypes = { | ||
| size: PropTypes.number.isRequired, |
There was a problem hiding this comment.
Since we are adding default values, we can remove the isRequired from propTypes.
| <Pressable | ||
| onPress={() => handleSpeedChange(audioPlaybackSpeed - 0.1)} | ||
| disabled={audioPlaybackSpeed < 1.0} | ||
| disabled={audioPlaybackSpeed <= 0.5} |
There was a problem hiding this comment.
Shouldn't this either be audioPlaybackSpeed < 0.5, or add <= in the handleSpeedChange function.
Collaborator
Author
There was a problem hiding this comment.
In the handleSpeedChange function, it returns when the value is < 0.5, but it should still accept 0.5. However, when the slider reaches 0.5, touch gets disabled.
- Translated localization strings for HOME, READ, and MUSIC to enhance user experience. - Updated ReadIcon component to set default props for size and color, improving flexibility and usability.
Gauravjeetsingh
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.