Support Owner Role Name and OwnerRole ID in Issuer / ClusterIssuer configuration #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irby
changed the title
irby
changed the base branch from
main
to
feat/AB#71008/enrollment-pattern-support
irby
changed the base branch from
feat/AB#71008/enrollment-pattern-support
to
release-2.3
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OwnerRoleName and OwnerRoleId fields to Issuer and ClusterIssuer configurations, providing the ability to specify certificate ownership roles during enrollment. The implementation includes comprehensive testing coverage and refactoring to improve unit testability.
- Added
OwnerRoleNameandOwnerRoleIdfields to both Issuer and ClusterIssuer specs with precedence logic (ID takes precedence over name) - Refactored the CSR enrollment request generation into a separate
buildCsrEnrollRequestmethod for better unit testing - Enhanced end-to-end tests to cover both Issuer and ClusterIssuer resources with the new owner role functionality
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/certificaterequest_controller.go | Passes new owner role fields from issuer spec to command configuration |
| internal/command/command_test.go | Adds comprehensive unit tests for the new buildCsrEnrollRequest method and owner role functionality |
| internal/command/command.go | Implements owner role support in CSR enrollment with annotation override capability |
| e2e/run_tests.sh | Extends e2e tests to validate owner role functionality for both Issuer and ClusterIssuer resources |
| Multiple CRD files | Updates Custom Resource Definitions to include ownerRoleId and ownerRoleName fields |
| Documentation files | Updates README and documentation to describe the new owner role fields and their usage |
docsource/content.md
Outdated
Comment on lines
218
to
219
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | ||
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
There was a problem hiding this comment.
There is a spelling error in 'tkae' which should be 'take'.
Suggested change
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
docsource/content.md
Outdated
Comment on lines
218
to
219
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | ||
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
There was a problem hiding this comment.
There is a spelling error in 'tkae' which should be 'take'.
Suggested change
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
README.md
Outdated
Comment on lines
250
to
251
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | ||
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
There was a problem hiding this comment.
There is a spelling error in 'tkae' which should be 'take'.
Suggested change
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
README.md
Outdated
Comment on lines
250
to
251
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | ||
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
There was a problem hiding this comment.
There is a spelling error in 'tkae' which should be 'take'.
Suggested change
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will tkae precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleId | The ID of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | | |
| | ownerRoleName | The name of the security role assigned as the certificate owner. The security role must be assigned to the identity context of the issuer. If `ownerRoleId` and `ownerRoleName` are both specified, `ownerRoleId` will take precedence. This field is **required** if the enrollment pattern, certificate template, or system-wide setting requires it. | |
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
doebrowsk
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OwnerRoleNameandOwnerRoleIdin ClusterIssuer resources. This field may be required if the certificate template / enrollment pattern / system-wide setting requires it.