Skip to content

Conversation

@irby
Copy link
Contributor

@irby irby commented May 28, 2025

  • Transition from using the deprecated keyfactor-go-client to keyfactor-go-client-sdk.
  • Add a fix to the GH Actions helm releaser so that it runs on tag pushes, and passes the correct tag version to the helm release job.
  • Add support for Enrollment Patterns (a new feature for Command 25+), allowing user to reference Enrollment Pattern by ID or by Name.
  • Separate the ambient credentials documentation into its own separate document, this improves readability of the overall documentation.
  • Add automated e2e tests to make it easy to run tests against the local codebase + Kubernetes.
  • Add logging of some of the claims generated by the ambient credentials. This will make it much easier to debug and setup the security claims / identity provider in Keyfactor Command.

Dependency updates also address some Dependabot alerts:

@irby irby changed the title Feat/ab#71008/enrollment pattern support v2.2.0: Support Enrollment Patterns Jun 3, 2025
@spbsoluble spbsoluble requested a review from Copilot July 7, 2025 20:15

This comment was marked as outdated.

@spbsoluble spbsoluble requested a review from Copilot July 7, 2025 21:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the issuer to support Keyfactor Command Enrollment Patterns (by ID or name), migrates to the new keyfactor-go-client-sdk, and adds corresponding tests, documentation, and CI fixes.

  • Migrated SDK import and client calls from keyfactor-go-client to keyfactor-go-client-sdk/v25
  • Extended SignConfig and CRDs to accept enrollmentPatternId and enrollmentPatternName, plus added lookup and fallback logic
  • Updated tests (unit and e2e), docs, and Helm workflows to reflect enrollment patterns and fixed chart release triggers

Reviewed Changes

Copilot reviewed 22 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/command/command.go Added fields & logic to populate EnrollmentPatternId/Name and updated client calls
internal/command/command_test.go New test cases for enrollment pattern support and adjusted fixtures
internal/command/client.go Extended Client interface and adapter to include GetEnrollmentPatterns
internal/command/command_test.go Missing expected: true in success-all-meta test case
api/v1alpha1/issuer_types.go Updated CRD struct tags and comments to deprecate certificateTemplate in favor of patterns
deploy/charts/.../issuers.yaml & clusterissuers.yaml Added enrollmentPatternId and enrollmentPatternName to CRDs
docs/ & e2e scripts Documentation updates for enrollment patterns; new e2e run_tests.sh
.github/workflows/helm.yml & keyfactor-bootstrap-workflow.yml Fixed Helm release trigger to run on tag pushes and updated action versions

},
"failure-missing-meta": {
presentMeta: []v1.CSSCMSDataModelModelsMetadataType{
{
Copy link

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The success-all-meta test case does not set expected: true, so it will default to false and fail. Add expected: true to this case.

Copilot uses AI. Check for mistakes.
@doebrowsk doebrowsk merged commit 3951496 into release-2.2 Jul 14, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants