-
Couldn't load subscription status.
- Fork 4
v2.2.0: Support Enrollment Patterns #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2.0: Support Enrollment Patterns #44
Conversation
…nt pattern name usage
…tokens can be used for API client
…of via pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the issuer to support Keyfactor Command Enrollment Patterns (by ID or name), migrates to the new keyfactor-go-client-sdk, and adds corresponding tests, documentation, and CI fixes.
- Migrated SDK import and client calls from
keyfactor-go-clienttokeyfactor-go-client-sdk/v25 - Extended
SignConfigand CRDs to acceptenrollmentPatternIdandenrollmentPatternName, plus added lookup and fallback logic - Updated tests (unit and e2e), docs, and Helm workflows to reflect enrollment patterns and fixed chart release triggers
Reviewed Changes
Copilot reviewed 22 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/command/command.go | Added fields & logic to populate EnrollmentPatternId/Name and updated client calls |
| internal/command/command_test.go | New test cases for enrollment pattern support and adjusted fixtures |
| internal/command/client.go | Extended Client interface and adapter to include GetEnrollmentPatterns |
| internal/command/command_test.go | Missing expected: true in success-all-meta test case |
| api/v1alpha1/issuer_types.go | Updated CRD struct tags and comments to deprecate certificateTemplate in favor of patterns |
| deploy/charts/.../issuers.yaml & clusterissuers.yaml | Added enrollmentPatternId and enrollmentPatternName to CRDs |
| docs/ & e2e scripts | Documentation updates for enrollment patterns; new e2e run_tests.sh |
| .github/workflows/helm.yml & keyfactor-bootstrap-workflow.yml | Fixed Helm release trigger to run on tag pushes and updated action versions |
| }, | ||
| "failure-missing-meta": { | ||
| presentMeta: []v1.CSSCMSDataModelModelsMetadataType{ | ||
| { |
Copilot
AI
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The success-all-meta test case does not set expected: true, so it will default to false and fail. Add expected: true to this case.
keyfactor-go-clienttokeyfactor-go-client-sdk.Dependency updates also address some Dependabot alerts: