Skip to content

added logging for troubleshooting #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

added logging for troubleshooting #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe6afa9
added logging for troubleshooting
joevanwanzeeleKF Oct 3, 2025
9f3a4ca
Update generated docs
Oct 3, 2025
0eda0ed
added additional logging
joevanwanzeeleKF Oct 6, 2025
426a3d8
Merge branch 'government_cloud_debug' of https://github.com/Keyfactor…
joevanwanzeeleKF Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AzureKeyVault/AzureKeyVault.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<PackageReference Include="BouncyCastle.NetCore" Version="2.2.1" />
<PackageReference Include="Keyfactor.Logging" Version="1.1.2" />
<PackageReference Include="Keyfactor.Orchestrators.Common" Version="3.2.0" />
<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="0.7.0" />
<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="1.0.0" />
<PackageReference Include="Keyfactor.Platform.IPAMProvider" Version="1.0.0" />
<PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="6.0.0" />
<PackageReference Include="Microsoft.Identity.Client" Version="4.68.0" />
Expand Down
15 changes: 7 additions & 8 deletions AzureKeyVault/Jobs/Management.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using Keyfactor.Orchestrators.Extensions.Interfaces;
using System.Collections.Generic;
using Newtonsoft.Json;
using System.Security.AccessControl;
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The System.Security.AccessControl import is unused in this file. Consider removing it to keep imports clean.

Suggested change
using System.Security.AccessControl;

Copilot uses AI. Check for mistakes.

namespace Keyfactor.Extensions.Orchestrator.AzureKeyVault
{
Expand All @@ -35,23 +36,21 @@ public JobResult ProcessJob(ManagementJobConfiguration config)

InitializeStore(config);

logger.LogTrace($"raw entry parameters from command: {JsonConvert.SerializeObject(config.JobProperties)}");

JobResult complete = new JobResult()
{
Result = OrchestratorJobStatusJobResult.Failure,
FailureMessage = "Invalid Management Operation"
};
object tagsObj;
object preserveTagsObj;

string tagsJSON;
bool preserveTags;

config.JobProperties.TryGetValue("CertificateTags", out tagsObj);

config.JobProperties.TryGetValue(EntryParameters.PRESERVE_TAGS, out preserveTagsObj);

preserveTags = (bool)preserveTagsObj;
logger.LogTrace("parsing entry parameters.. ");

tagsJSON = tagsObj as string;
tagsJSON = config.JobProperties[EntryParameters.TAGS] as string ?? string.Empty;
preserveTags = config.JobProperties[EntryParameters.PRESERVE_TAGS] as bool? ?? false;

switch (config.OperationType)
{
Expand Down
Loading
Loading