Skip to content

Conversation

@forrest79
Copy link
Contributor

Proof of concept yet...

  • new RedisSharedClient based on RedisClient, but share one driver for many connections
  • I am not sure with names (obviously), I made ConnectionPool, but it is pool of drivers... For me connection better describes what it is, but it could be confusing because it is drivers...
  • I don't make DI config yet, I have no idea, what config can be set to use RedisSharedClient instead of RedisClient
  • disadvantage: if user get driver with getDriver() method, than user have to expected, that some RedisSharedClient can change database...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be your name ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He, yes, thanks :-)

@forrest79
Copy link
Contributor Author

When you will have a minute, can you take a look at last notes? :-) Thanks

@fprochazka
Copy link
Member

I like it :) I just need to look at the code more thoroughly and then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants