Skip to content

Conversation

@k4k7us23
Copy link
Contributor

  • In my project I am using DrawableMatcher to find an ImageView by drawable inside it
  • I discovered that DrawableMatcher fails with NullPointerException, in case view hierarchy contains an ImageView without any Drawable inside
  • This PR adds EmptyDrawableMatcherTest, that reproduces scenario described above
  • EmptyDrawableMatcherTest is marked with ignore annotation, as DrawableMatcher will be fixed in a separate PR

@k4k7us23 k4k7us23 requested review from Unlimity and Vacxe as code owners June 18, 2025 17:14
Copy link
Contributor

@Unlimity Unlimity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Although given the fact that no one noticed and reported it before means this case is super rare

@Vacxe
Copy link
Member

Vacxe commented Jun 19, 2025

@k4k7us23 thanks for the contribution. Will create a new release ASAP.

@Vacxe Vacxe changed the base branch from master to develop June 19, 2025 08:26
@Vacxe Vacxe merged commit db4025b into KakaoCup:develop Jun 19, 2025
3 of 11 checks passed
@Vacxe
Copy link
Member

Vacxe commented Jun 19, 2025

@k4k7us23 any ETA for the fix or you wanna delegate fix to me?

@Vacxe
Copy link
Member

Vacxe commented Jun 19, 2025

Ref: #144

@k4k7us23
Copy link
Contributor Author

@Vacxe I am planning to make a fix at the end of this week. Feel free to fix it yourself, if it's urgent

@Vacxe
Copy link
Member

Vacxe commented Jun 19, 2025

@k4k7us23 thank mate, appreciate. Please create a PR when you have a chance 😉 looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants