Make sure the game ends if either team guesses correctly #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dster2
reviewed
May 23, 2024
| if one_guessed and not two_guessed: | ||
| end_game(active2, inactive2, 0, DONE, DONE) | ||
| elif two_guessed and not one_guessed: | ||
| end_game(active1, inactive1, 0, DONE, DONE) |
There was a problem hiding this comment.
Shouldn't we also end if both guess?
There was a problem hiding this comment.
It will already be taken care of in the guesser_action where they will be given reward and set status to DONE
There was a problem hiding this comment.
In that case, you don't need the wrapper if one_guessed or two_guessed clause?
dster2
approved these changes
May 23, 2024
| if one_guessed and not two_guessed: | ||
| end_game(active2, inactive2, 0, DONE, DONE) | ||
| elif two_guessed and not one_guessed: | ||
| end_game(active1, inactive1, 0, DONE, DONE) |
There was a problem hiding this comment.
In that case, you don't need the wrapper if one_guessed or two_guessed clause?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/342416334