-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add cool features to iOS app #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rahul-Sahani04
wants to merge
4
commits into
KRTirtho:master
Choose a base branch
from
Rahul-Sahani04:My-Cool-Features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add features to display current playing track information and support media controls on iOS. * **HomePlayerWidget.swift** - Add track title, artist name, and album art display in the HomePlayerWidget. - Update SimpleEntry struct to include trackTitle, artistName, and albumArt properties. - Modify placeholder, getSnapshot, and getTimeline methods to include new properties. - Update HomePlayerWidgetEntryView to display new track information. * **Info.plist** - Add support for media controls on the lock screen and control center. - Add integration with Siri for voice commands to control playback. * **main.dart** - Register the HomePlayerWidget for iOS by adding glanceProvider listener. * **glance.dart** - Add code to update the HomePlayerWidget with the current track information, including track title, artist name, and album art.
Add enhanced media controls and social sharing features. * **Enhanced Media Controls:** - Add volume control slider to `PlayerControls` widget in `lib/modules/player/player_controls.dart`. - Implement keyboard shortcuts for media controls (play/pause, next/previous track, volume up/down) in `PlayerControls` widget. - Add "lyrics" button to `PlayerView` widget in `lib/modules/player/player.dart`. * **Social Sharing Features:** - Add feature to share the currently playing track on social media platforms in `lib/components/track_tile/track_options.dart`. - Add share button to `TrackPresentationTopSection` widget in `lib/components/track_presentation/presentation_top.dart`. * **Settings:** - Add dark mode toggle in the settings page in `lib/pages/settings/settings.dart`. * **CI Configuration:** - Add `.ci.yaml` file for continuous integration configuration.
Enhance media controls and add social sharing features
Would love to see this in new version. Fix the conflicts and you'll get my approve. |
Conflicts resolved and merged. Ready for review. |
lori28167
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better UI. Really nice
Thanks. I'm Happy that you liked the UI improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add features to display current playing track information and support media controls on iOS.
HomePlayerWidget.swift
Info.plist
main.dart
glance.dart