Skip to content

feat: Implement 'revoke' for Issuer #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 30, 2025
Merged

feat: Implement 'revoke' for Issuer #930

merged 14 commits into from
Jan 30, 2025

Conversation

abdulmth
Copy link
Contributor

fixes KILTProtocol/ticket#3646

replaces #918

@abdulmth abdulmth mentioned this pull request Jan 14, 2025
5 tasks
@abdulmth abdulmth changed the title Implement 'revoke' for Issuer feat: Implement 'revoke' for Issuer Jan 15, 2025
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstrings need some love but otherwise I think this looks pretty damn good!

abdulmth and others added 3 commits January 16, 2025 10:36
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
@abdulmth abdulmth marked this pull request as ready for review January 16, 2025 12:29
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks now, then we're done here 😬

@abdulmth abdulmth requested a review from rflechtner January 20, 2025 09:29
@abdulmth abdulmth merged commit 74f4d5c into develop Jan 30, 2025
12 of 14 checks passed
@abdulmth abdulmth deleted the revoke-implementation branch January 30, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants