Skip to content

docs: remove github docs publish #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

ChrisChinchilla
Copy link
Contributor

fixes KILTProtocol/ticket#3578

Move v1 SDK docs to Amplify and remove from GitHub pages.

@ChrisChinchilla ChrisChinchilla requested a review from ggera August 15, 2024 14:57
@ChrisChinchilla
Copy link
Contributor Author

These are now working

kit-js.kilt.io
kilt-js-old.kilt.io

So this is ready to merge.

@ggera
Copy link
Member

ggera commented Aug 20, 2024

These are now working

kit-js.kilt.io kilt-js-old.kilt.io

So this is ready to merge.

Adios old page 🚀 , what is the strategy for href reference on the docs repo? Either replace

  1. https://kiltprotocol.github.io/sdk-js/ with https://kilt-js-old.kilt.io/) on release-0.35.0 branch
  2. https://kiltprotocol.github.io/sdk-js/ with https://kilt-js.kilt.io/) on develop
    or keep it as before and create a issue ticket to delete this github page

@rflechtner
Copy link
Contributor

Any reason one is kit-js and the other kilt-js ? is that a typo or a deliberate choice?

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, removing this wf seems fine to me.

@ggera
Copy link
Member

ggera commented Aug 22, 2024

Any reason one is kit-js and the other kilt-js ? is that a typo or a deliberate choice?

Typo, renamed it to kilt-js.kilt.io

@ChrisChinchilla ChrisChinchilla merged commit 55aa2fb into develop Aug 22, 2024
13 of 14 checks passed
@ChrisChinchilla ChrisChinchilla deleted the chrisward/remove-v1-docs branch August 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants