Skip to content

refactor!: update sdk surface #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2024
Merged

refactor!: update sdk surface #893

merged 4 commits into from
Aug 5, 2024

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jul 30, 2024 •
edited
Loading

https://github.com/KILTprotocol/ticket/issues/3502

  • Removes signAndSubmitTx
  • Updates some outdated docstrings

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner marked this pull request as ready for review July 31, 2024 15:37
ntn-x2
ntn-x2 approved these changes Aug 5, 2024
View reviewed changes
@rflechtner rflechtner merged commit 55aa03d into develop Aug 5, 2024
14 checks passed
@rflechtner rflechtner deleted the rf-update-skd-surface branch August 5, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@abdulmth abdulmth abdulmth approved these changes

@Dudleyneedham Dudleyneedham Awaiting requested review from Dudleyneedham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rflechtner @ntn-x2 @abdulmth