refactor!: align issuer/holder interfaces #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
reviewed
Jul 23, 2024
packages/jsonld-suites/src/suites/KiltAttestationProofV1.spec.ts
Outdated
Show resolved
Hide resolved
Dudleyneedham
requested changes
Jul 23, 2024
abdulmth
approved these changes
Jul 24, 2024
rflechtner
added a commit
that referenced
this pull request
Jul 24, 2024
* feat: create DID signers from signers or keypairs * feat: transact did helper * feat: createDid did helper * feat: setVerificationMethod did helper * feat: addService did helper * feat: claimWeb3Name did helper * feat: releaseWeb3Name did helper * feat: removeVM did helper * feat: implement deactivateDid * feat: generateKeypair helper using multikey encoding * fix: add missing implementation on getSignersForKeypair * refactor!: align issuer/holder interfaces (#889) * test: fix unit tests * test: integration tests for did helpers * chore(deps): bump jcs versions * chore: set alpha.2 versions --------- Co-authored-by: Raphael Flechtner <raphael@kilt.io> Co-authored-by: Abdulrahim Al Methiab <abdul@kilt.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/3533
Makes sure that issuer and holder interfaces integrate nicely with the DidHelpers.
To avoid imports from
sdk-js, I moved DidHelper interfaces to thetypespackage.didDocumentandsignerswith typings identical to those used in DidHelpers; plain Dids are no longer accepted.transact.How to test:
I added a DidHelpers integration tests that shows how
transactcan be used to build custom submission logic.Checklist: