fix: transaction result serialization

[abdulmth]

fixes https://github.com/KILTprotocol/ticket/issues/3529

Adds toJSON implementation to the TransactionResult objects that include a block number.
Another way to solve the serialization issue is to change the block number type to string.

[rflechtner]

Did you check if stringifying the result object now works? I suspect that due to the getters this will still be a problem, and we likely have to implement toJSON() on the root as well

[abdulmth]

@rflechtner It doesn't work because stringify tries to call the getters, and they will throw except one. But why do we need to implement it for the root? users should match the status anyways before doing anything, and having keys like asConfirmed are meant for conversion rather as a JSON key.

[rflechtner]

@rflechtner It doesn't work because stringify tries to call the getters, and they will throw except one. But why do we need to implement it for the root? users should match the status anyways before doing anything, and having keys like asConfirmed are meant for conversion rather as a JSON key.

I thought so and wondered if we should allow stringifying to either something like

{
   status: 'confirmed',
   value: {
     block: {...},
     ...
   }
}

or

{
   status: 'confirmed',
   block: {...},
   ...
}

[rflechtner]

👍