Refactor checkResult()
#886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
force-pushed
the
abd-chore-refactor-check-result
branch
from
aaea545 to
7484bd5
Compare
rflechtner
reviewed
Jul 18, 2024
Comment on lines
55
to
58
| let status: TransactionResult['status'] | undefined | ||
| let blockHash | ||
| let blockNumber | ||
| let error |
There was a problem hiding this comment.
let's use returns inside of the switch instead
Comment on lines
25
to
26
| let error | ||
| txEvents.forEach(({ event }) => { |
There was a problem hiding this comment.
Suggested change
| let error | |
| txEvents.forEach(({ event }) => { | |
| return txEvents.find(({ event }) => { |
combine this with returns (I'll make one example below) and our function becomes simpler and faster (exits on first error)
| const isSuccess = !error && eventMatch | ||
|
|
||
| status = isSuccess ? 'confirmed' : 'failed' | ||
| if (!isSuccess && !error) { |
There was a problem hiding this comment.
Suggested change
| if (!isSuccess && !error) { | |
| if (!isSuccess && !eventMatch) { |
why not be more explicit?
| } from './interfaces.js' | ||
|
|
||
| function mapError(err: SpRuntimeDispatchError, api: ApiPromise): Error { | ||
| export function mapError(err: SpRuntimeDispatchError, api: ApiPromise): Error { |
There was a problem hiding this comment.
this one and the next are only used in checkResult rn, so they could move there too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.