Skip to content

refactor: various did helper refactors, code deduplication & lint fixes #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2024
Merged

refactor: various did helper refactors, code deduplication & lint fixes #882

merged 7 commits into from
Jul 17, 2024

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jul 17, 2024 •
edited
Loading

Reduces code duplication, reorganises some code, and fixes linter errors.

How to test:

Unit & integration tests should pass.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner requested a review from abdulmth July 17, 2024 12:17
@abdulmth abdulmth merged commit 8bf30cd into rf-did-helpers Jul 17, 2024
4 checks passed
@abdulmth abdulmth deleted the rf-did-helper-refactors branch July 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulmth abdulmth abdulmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @abdulmth