DidHelper Remove Verification Method #876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
changed the title
rflechtner
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
LGTM! I'd personally like to have a sign-off by @Dudleyneedham & @ntn-x2 given that removing verification methods was not part of the finalised and agreed-upon solution doc (https://hackmd.io/YEKFloxtR36v5w1ODppszA?view), but I think we have a workable solution here. Once VM management becomes more flexible, we can start making some parameters optional (e.g., the relationship parameter).
Dudleyneedham
approved these changes
Jul 17, 2024
| @@ -82,3 +84,79 @@ export function setVerificationMethod( | |||
| expectedEvents: [{ section: 'did', method: 'DidUpdated' }], | |||
| }) | |||
| } | |||
|
|
|||
| /** | |||
| * Removes the verification method for the selected `verificationMethodId` and `relationship`. | |||
There was a problem hiding this comment.
Suggested change
| * Removes the verification method for the selected `verificationMethodId` and `relationship`. | |
| * Removes the verification method for the selected `verificationMethodId` and `relationship`. |
|
I guess this can be closed now, given that it's been merged with #880? |
ntn-x2
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3368