Skip to content

chore: update to node v20 #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 8, 2024
Merged

chore: update to node v20 #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1fcc2c7
chore: bump github workflow actions to v4 (compatible with node 20)
Jun 12, 2024
c0f1d02
chore: update action in action to v4
Jun 12, 2024
c2df147
fix: use docker image with node 20 pre-installed
Jun 12, 2024
5ef6bf2
fix: try to fox integration tests
Jun 12, 2024
fcf4b87
feat: test against node v22 on workflows as well
Jun 12, 2024
2afc5fe
fix: make node v22 on github workflows optional
Jun 17, 2024
bddedbc
fix: fix: make node v22 on github workflows optional
Jun 17, 2024
87fea3a
fix: try to reproduce green checks
Jun 17, 2024
ada4a74
fix: last try to make node v22 optional
Jul 2, 2024
3979601
chore: update aws action to use node 20 = bump to v4
Jul 3, 2024
c4b1e55
chore: update other aws action to use node 20 = bump to v2
Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/cached-image-pull/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runs:

- name: check image cache
id: image-cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.image-file.outputs.path }}
key: image-cache-${{ inputs.image }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/devpackpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ jobs:
runs-on: ubuntu-latest
if: "! startsWith(github.event.head_commit.message, '[CI Skip]') && github.repository == 'kiltprotocol/sdk-js'"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# fetch-depth 0 and token needed to push changes on the package.json files back.
fetch-depth: 0
token: ${{ secrets.REPO_ACCESS_TOKEN }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install and Build
run: |
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/npmpublish-rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand All @@ -31,8 +31,8 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand All @@ -44,9 +44,9 @@ jobs:
run: yarn run bundle
- name: Get current package version
id: package_version
run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT
run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT
- name: Publish to NPM
run: yarn run publish --tag ${{ inputs.npm_tag }}
run: yarn run publish --tag ${{ inputs.npm_tag }}
env:
YARN_NPM_AUTH_TOKEN: ${{secrets.npm_token}}
- name: Repository Dispatch
Expand All @@ -55,4 +55,4 @@ jobs:
token: ${{ secrets.REPO_ACCESS_TOKEN }}
repository: KILTProtocol/docs
event-type: sdk-update
client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}'
client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}'
12 changes: 6 additions & 6 deletions .github/workflows/npmpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand All @@ -19,8 +19,8 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand All @@ -32,7 +32,7 @@ jobs:
run: yarn run bundle
- name: Get current package version
id: package_version
run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT
run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT
- name: Publish to NPM
run: yarn run publish --tag latest
env:
Expand All @@ -43,4 +43,4 @@ jobs:
token: ${{ secrets.REPO_ACCESS_TOKEN }}
repository: KILTProtocol/docs
event-type: sdk-update
client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}'
client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}'
33 changes: 16 additions & 17 deletions .github/workflows/test-node-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@ env:
TESTCONTAINERS_WATCHER_IMG: testcontainers/ryuk:0.3.2

jobs:

build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'yarn'
Expand All @@ -30,7 +29,7 @@ jobs:
- name: zip build
run: zip -r build.zip .
- name: upload build
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build
path: build.zip
Expand All @@ -39,7 +38,7 @@ jobs:
runs-on: ubuntu-latest
needs: build
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: make sure testcontainers image is in cache
uses: ./.github/actions/cached-image-pull
with:
Expand All @@ -51,28 +50,28 @@ jobs:
needs: cache_imgs

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build
- name: unzip
run: unzip build.zip -d .
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
- name: Log out node version
run: node --version

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1

- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
uses: aws-actions/amazon-ecr-login@v2

- name: pull image
env:
Expand All @@ -97,19 +96,19 @@ jobs:
needs: build

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build
- name: unzip
run: unzip build.zip -d .
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
- name: yarn bundle
run: yarn bundle
- name: upload bundle artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: checked-nonmin-bundle
path: packages/sdk-js/dist/sdk-js.umd.js
Expand All @@ -120,29 +119,29 @@ jobs:
needs: [cache_imgs, bundle_cache]

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build
- name: unzip
run: unzip build.zip -d .
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: checked-nonmin-bundle
path: packages/sdk-js/dist
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
- run: basename /packages/sdk-js/dist/
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1

- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
uses: aws-actions/amazon-ecr-login@v2
- name: pull node image
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/tests-polkadot-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: master
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
Expand All @@ -35,7 +35,7 @@ jobs:
- name: list dependencies
run: echo "$(yarn info -A --name-only --json)" > locked_dependencies.txt
- name: upload dependencies list
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: deps-${{ matrix.node-version }}
path: |
Expand All @@ -47,7 +47,7 @@ jobs:
- name: zip build
run: zip -r build.zip .
- name: upload build
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-${{ matrix.node-version }}
path: build.zip
Expand All @@ -63,11 +63,13 @@ jobs:
include:
- node-version: 16.x
required: 'optional'
- node-version: 22.x
required: 'optional'

continue-on-error: ${{ matrix.required == 'optional' }}

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-${{ matrix.node-version }}
- name: unzip
Expand All @@ -91,7 +93,7 @@ jobs:
continue-on-error: ${{ matrix.required == 'optional' }}

steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-20.x
- name: unzip
Expand All @@ -106,9 +108,9 @@ jobs:

- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
uses: aws-actions/amazon-ecr-login@v2

- name: pull image
- name: pull node image
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
ECR_REPOSITORY: kilt/prototype-chain
Expand All @@ -135,7 +137,7 @@ jobs:
needs: [test, integration_test]
if: failure()
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: deps-20.x
- name: set dependencies env
Expand Down
Loading