Skip to content

chore: release 0.35.1 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2024
Merged

chore: release 0.35.1 #863

merged 8 commits into from
May 2, 2024

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Apr 29, 2024 •
edited
Loading

Partially fixes https://github.com/KILTprotocol/ticket/issues/3057.

Checklist

  • Review the current PR
  • Release an RC
  • Integrate into DIP SDK
  • Verify correctness
  • Release official version

@ntn-x2 ntn-x2 changed the base branch from develop to master April 29, 2024 13:03
@ntn-x2 ntn-x2 self-assigned this Apr 29, 2024
@ntn-x2 ntn-x2 requested a review from rflechtner April 29, 2024 13:03
rflechtner
rflechtner reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd suggest we publish the RC from this branch though and merge only once the version is bumped to the full release

@ntn-x2 ntn-x2 added the ✋on hold status: on hold label Apr 29, 2024
@ntn-x2 ntn-x2 removed the ✋on hold status: on hold label May 2, 2024
@ntn-x2 ntn-x2 marked this pull request as ready for review May 2, 2024 08:13
@ntn-x2
Copy link
Member Author

ntn-x2 commented May 2, 2024

@rflechtner I bumped the version to 0.35.1, after I verified that everything works as expected in the DIP SDK. Should we merge and release?

rflechtner
rflechtner approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lovely!

@ntn-x2 ntn-x2 merged commit aafd5ae into master May 2, 2024
@ntn-x2 ntn-x2 deleted the aa/0.35.1 branch May 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

Assignees

@ntn-x2 ntn-x2

Labels
🗺️ DIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntn-x2 @rflechtner