Skip to content

feat: tiny change to create a pr 3735 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

aybarsayan
Copy link

When I talked to Dudley, he said I needed to make my PRs smaller, so I'm starting from the very beginning. This is exactly the same as the current main, and if you approve this, I will make another small change and proceed from there. (Note: I was unable to send PR because its litterily the main branch, so I did the littlest change and then send a pr)

@aybarsayan aybarsayan changed the title feat: tiny change to create a pr #3735 feat: tiny change to create a pr https://github.com/KILTprotocol/ticket/issues/3735 Feb 17, 2025
@aybarsayan aybarsayan changed the title feat: tiny change to create a pr https://github.com/KILTprotocol/ticket/issues/3735 feat: tiny change to create a pr 3735 Feb 17, 2025
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-340.d3oeht7cvddn19.amplifyapp.com

@@ -259,7 +259,7 @@ module.exports = {
content: trimContent,
}
}
return undefined
return undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Is this to make a PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 😅 otherwise it doesn't allow me to create a pr so I did the simplest and littest change I possibly can 😅

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're going to open PRs against the new-sdkv1 branch now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants