-
Notifications
You must be signed in to change notification settings - Fork 19
Update workshop to v1 of SDK #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
code_examples/sdk_examples/src/workshop/issuer/generateAccount.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
…nto 3594-update-workshop Signed-off-by: Chris Chinchilla <chris@kilt.io> # Conflicts: # sdk/02_tutorial/03_overview.md
Signed-off-by: Chris Chinchilla <chris@kilt.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some nitpicks remaining
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
@rflechtner If you're good with it now, let's get this merged into the SDK branch and I will fix the code transclusion now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks!
fixes KILTProtocol/ticket#3594