-
Notifications
You must be signed in to change notification settings - Fork 87
CMake: option for WASM build #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
c8cd2ad
to
cc323d9
Compare
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
ahayzen-kdab
reviewed
May 1, 2024
7702abe
to
1fd62e5
Compare
ahayzen-kdab
reviewed
May 2, 2024
ahayzen-kdab
reviewed
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 70 70
Lines 12011 12011
=========================================
Hits 12011 12011 ☔ View full report in Codecov by Sentry. |
849e29f
to
f34d85c
Compare
f34d85c
to
04bb5b2
Compare
94640fd
to
9cacc29
Compare
Option `BUILD_WASM` to specify WebAssembly as target arch Support building current main branch with emscripten 3.1.14 Only build qml_minimal example for WASM target
9cacc29
to
fe041dc
Compare
ahayzen-kdab
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option
BUILD_WASM
to specify WebAssembly as target archSupport building current main branch with emscripten