Place all objects and passthrough items in the same block, to pass th… #1282
+184
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12795 +23
=========================================
+ Hits 12772 12795 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@BenFordTytherington what is the use-case for this, especially the An extern block is not a module, so does the documentation even end up anywhere readable? |
BenFordTytherington
force-pushed
the
pass-cfg-everywhere
branch
from
7f256a6 to
fac4c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately, it would be good to preserve the blocks things appear in, so if you place a cfg or doc attribute on the top of a block, it is preserved in the final code, but this requires significant rewriting, so work is beginning by slowly grouping things into the same extern block, and passing through docs.