Skip to content

Fix method ambiguity for adjoint multiplication with Symbolics.Arr #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix method ambiguity for adjoint multiplication with Symbolics.Arr #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/array-lib.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ function _matvec(A, b)
end
end
@wrapped (*)(A::AbstractMatrix, b::AbstractVector) = _matvec(A, b) false
@wrapped (*)(x::Adjoint{T, <:AbstractVector} where {T}, A::Symbolics.Arr{<:Any, 2}) = _matmul(x, A) false

# specialize `dot` to dispatch on `Symbolic{<:Number}` to eventually work for
# arrays of (possibly unwrapped) Symbolic types, see issue #831
Expand Down
6 changes: 6 additions & 0 deletions test/arrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ getdef(v) = getmetadata(v, Symbolics.VariableDefaultValue)
symvec = [sym3(symT), sym4(symT)]
@test isequal(symvec'weights, weights'symvec)

# Issue #575: test adjoint multiplication with Symbolics.Arr to resolve method ambiguity
@variables d[1:2] E[1:2, 1:2]
# This should not throw a method ambiguity error
result = d' * E
@test isa(result, Symbolics.Arr)

# ModelingToolkit.jl#1736
#
@variables t F(t)[1:1]
Expand Down
Loading