Fix incorrect code generated for Symbolics.build_function(Symbolics.derivative(mod(x), x)) #1123 #1514
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erivative(mod(x), x))
…erivative(mod(x), x))
…erivative(mod(x), x))
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 8.79% 15.87% +7.08%
==========================================
Files 51 51
Lines 4924 5007 +83
==========================================
+ Hits 433 795 +362
+ Misses 4491 4212 -279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test failures |
…erivative(mod(x), x))
…erivative(mod(x), x))
|
Tests still fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule for handling derivatives of the mod function and introduces corresponding test cases. Additionally, we integrate FiniteDiff for testing derivative values to ensure correctness. These changes aim to improve the accuracy and reliability of derivative calculations.