Fix sympy test #1009
Merged
Fix sympy test #1009
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failin localy with
Expression: SymPy.simplify(symbolics_to_sympy(Symbolics.solve_for(expr, p))) == (SymPy.solve(sexpr, sp))[1]
Evaluated: -2*t*(x^2 + y(t) - 1)/(x^2 + x + y(t) - 1) == 2*t*(-x^2 - y(t) + 1)/(x^2 + x + y(t) - 1)
While equal, they are not the same expression. `SymPy.simplify` and
`SymPy.solve` don't seem to guarantee identical expressions, so pass
both results through `simplify` to ensure they are comparable.
ChrisRackauckas
approved these changes
Nov 12, 2023
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
+ Coverage 80.58% 80.73% +0.14%
==========================================
Files 51 51
Lines 5136 5233 +97
==========================================
+ Hits 4139 4225 +86
- Misses 997 1008 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for correcting it |
ChrisRackauckas
merged commit be34414
into
JuliaSymbolics:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing locally with
While equal, they are not the same expression.
SymPy.simplifyandSymPy.solvedon't seem to guarantee identical expressions, so pass both results throughsimplifyto ensure they are comparable.