Skip to content

[WIP] refactor: move to Moshi #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Jun 27, 2025

Currently implemented to be mostly identical to the old ADT. Will add Const and ArrayOp in future PRs to be able to limit the scope of individual PRs.

We don't want to repeat the MTKv10 PR :D

Copy link
Contributor

github-actions bot commented Jun 27, 2025

Benchmark Results

master c3cc461... master / c3cc461...
overhead/acrule/a+2 0.956 ± 0.25 μs 0.937 ± 0.3 μs 1.02 ± 0.42
overhead/acrule/a+2+b 0.949 ± 0.25 μs 1.15 ± 0.29 μs 0.825 ± 0.3
overhead/acrule/a+b 0.276 ± 0.024 μs 0.23 ± 0.024 μs 1.2 ± 0.16
overhead/acrule/noop:Int 1.55 ± 0.01 ns 1.56 ± 0.01 ns 0.995 ± 0.009
overhead/acrule/noop:Sym 25.9 ± 6 ns 22 ± 6.3 ns 1.18 ± 0.43
overhead/get_degrees/large_poly 0.156 ± 0.0077 s 0.0987 ± 0.006 s 1.58 ± 0.12
overhead/rule/noop:Int 0.0352 ± 0.023 μs 0.0565 ± 0.024 μs 0.623 ± 0.49
overhead/rule/noop:Sym 0.0331 ± 0.023 μs 0.0654 ± 0.025 μs 0.506 ± 0.4
overhead/rule/noop:Term 0.0333 ± 0.024 μs 0.0658 ± 0.026 μs 0.505 ± 0.41
overhead/ruleset/noop:Int 0.121 ± 0.032 μs 0.122 ± 0.04 μs 0.996 ± 0.42
overhead/ruleset/noop:Sym 0.123 ± 0.036 μs 0.139 ± 0.046 μs 0.886 ± 0.39
overhead/ruleset/noop:Term 4.92 ± 0.75 μs 8.5 ± 0.9 μs 0.578 ± 0.11
overhead/simplify/noop:Int 0.25 ± 0.034 μs 0.269 ± 0.02 μs 0.929 ± 0.14
overhead/simplify/noop:Sym 0.246 ± 0.032 μs 0.295 ± 0.0084 μs 0.835 ± 0.11
overhead/simplify/noop:Term 0.0502 ± 0.0048 ms 0.0961 ± 0.009 ms 0.523 ± 0.07
overhead/simplify/randterm (+, *):serial 0.131 ± 0.0099 s 0.254 ± 0.02 s 0.517 ± 0.057
overhead/simplify/randterm (+, *):thread 0.0738 ± 0.0059 s 0.151 ± 0.0092 s 0.489 ± 0.049
overhead/simplify/randterm (/, *):serial 0.253 ± 0.024 ms 0.38 ± 0.027 ms 0.667 ± 0.08
overhead/simplify/randterm (/, *):thread 0.289 ± 0.028 ms 0.411 ± 0.036 ms 0.704 ± 0.091
overhead/substitute/a 0.104 ± 0.0097 ms 0.17 ± 0.02 ms 0.613 ± 0.091
overhead/substitute/a,b 0.0878 ± 0.0086 ms 0.135 ± 0.018 ms 0.649 ± 0.11
overhead/substitute/a,b,c 19.3 ± 1.9 μs 14.8 ± 2.3 μs 1.31 ± 0.24
polyform/easy_iszero 0.0414 ± 0.0061 ms 0.104 ± 0.013 ms 0.397 ± 0.078
polyform/isone 4.02 ± 0.92 ns 2.79 ± 0 ns 1.44 ± 0.33
polyform/iszero 1.43 ± 0.041 ms 4.09 ± 0.34 ms 0.35 ± 0.031
polyform/simplify_fractions 1.93 ± 0.06 ms 3.84 ± 0.3 ms 0.504 ± 0.042
time_to_load 1.18 ± 0.015 s 1.24 ± 0.02 s 0.952 ± 0.019

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@AayushSabharwal
Copy link
Member Author

The transition is more or less complete. However, we are currently much slower. I'll investigate why.

@AayushSabharwal AayushSabharwal force-pushed the v4 branch 2 times, most recently from 5aedec5 to 3057632 Compare July 4, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant