Skip to content

Draft: Complete Overhaul of Egraphs (even faster) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 72 commits into from

Conversation

0x0f0f0f
Copy link
Member

@0x0f0f0f 0x0f0f0f commented Jan 12, 2024

New simplified term interface - new rebuild - compact enodes as UInt vectors - simplified analysis

Copy link

github-actions bot commented Jan 12, 2024

Benchmark Results

master 4229c34... t[master]/t[4229c34...]
basic_maths/simpl1 0.0581 ± 0.0042 s 28.5 ± 3.8 ms 2.04
calc_logic/demorgan 0.613 ± 0.013 ms 0.424 ± 0.0091 ms 1.45
egraph/addexpr 19.6 ± 1.2 ms 8.78 ± 0.4 ms 2.23
egraph/constructor 0.588 ± 0.024 μs 0.794 ± 0.048 μs 0.74
prop_logic/demorgan 0.984 ± 0.02 ms 0.539 ± 0.012 ms 1.83
prop_logic/freges_theorem 0.0395 ± 0.0033 s 13.4 ± 0.29 ms 2.96
prop_logic/prove1 0.445 ± 0.025 s 0.133 ± 0.002 s 3.36
prop_logic/rewrite 0.0771 ± 0.0015 ms 0.049 ± 0.0012 ms 1.57
while_superinterpreter/while_10 0.122 ± 0.0012 s 0.0647 ± 0.00096 s 1.89
time_to_load 0.257 ± 0.00099 s 0.155 ± 0.00056 s 1.66

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (85f608b) 69.11% compared to head (4229c34) 75.57%.

Files Patch % Lines
src/EGraphs/egraph.jl 84.61% 34 Missing ⚠️
src/TermInterface.jl 81.57% 7 Missing ⚠️
src/EGraphs/saturation.jl 93.33% 5 Missing ⚠️
src/Rules.jl 0.00% 5 Missing ⚠️
src/Rewriters.jl 55.55% 4 Missing ⚠️
src/extras/graphviz.jl 0.00% 4 Missing ⚠️
src/Syntax.jl 90.00% 3 Missing ⚠️
src/Patterns.jl 85.71% 2 Missing ⚠️
src/EGraphs/extract.jl 97.91% 1 Missing ⚠️
src/matchers.jl 94.44% 1 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   69.11%   75.57%   +6.46%     
==========================================
  Files          16       19       +3     
  Lines        1350     1261      -89     
==========================================
+ Hits          933      953      +20     
+ Misses        417      308     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0x0f0f0f 0x0f0f0f changed the title Draft: New term interface Draft: Complete Overhaul of Egraphs: New simplified term interface - new rebuild - compact enodes as UInt vectors Jan 13, 2024
@0x0f0f0f 0x0f0f0f changed the title Draft: Complete Overhaul of Egraphs: New simplified term interface - new rebuild - compact enodes as UInt vectors Draft: Complete Overhaul of Egraphs (even faster) Jan 13, 2024
@0x0f0f0f
Copy link
Member Author

Moved to ale/3.0 branch #185

@0x0f0f0f 0x0f0f0f closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants