breakage workflow: update permissions #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final step of the breakage workflow (breakage/upload) fails when a pull request comes from a fork because GITHUB_TOKEN restricts permissions in that scenario. This PR always allows breakage/upload to run.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/Breakage.yml:4
- Review whether granting write permissions on both contents and pull-requests introduces any unintended security risks in the workflow. Ensure these permissions are the minimal required for the intended functionality.
# allow breakage/upload when a PR comes from a fork
|
|
So, there is no need for JuliaSmoothOptimizers/Krylov.jl@f4d9549 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final step of the breakage workflow (breakage/upload) fails when a pull request comes from a fork because GITHUB_TOKEN restricts permissions in that scenario. This PR always allows breakage/upload to run.