Skip to content

breakage workflow: update permissions #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

breakage workflow: update permissions #372

wants to merge 1 commit into from

Conversation

dpo
Copy link
Member

@dpo dpo commented Apr 9, 2025

The final step of the breakage workflow (breakage/upload) fails when a pull request comes from a fork because GITHUB_TOKEN restricts permissions in that scenario. This PR always allows breakage/upload to run.

The final step of the breakage workflow (breakage/upload)
fails when a pull request comes from a fork because
GITHUB_TOKEN restricts permissions in that scenario.
This PR always allows breakage/upload to run.
@dpo dpo requested review from tmigot and Copilot April 9, 2025 22:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/Breakage.yml:4

  • Review whether granting write permissions on both contents and pull-requests introduces any unintended security risks in the workflow. Ensure these permissions are the minimal required for the intended functionality.
# allow breakage/upload when a PR comes from a fork

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

@tmigot
Copy link
Member

tmigot commented Apr 16, 2025

So, there is no need for JuliaSmoothOptimizers/Krylov.jl@f4d9549 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants