Skip to content

Remove inverses in LSR1 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

MaxenceGollier
Copy link
Contributor

#367

We should also add something in the tutorial limited_memory_bfgs_and_sr1 to say that since SR1 can be undefinite, only the forward operator is implemented.

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (32dbc5e) to head (048460f).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   95.00%   94.25%   -0.75%     
==========================================
  Files          17       20       +3     
  Lines        1100     1148      +48     
==========================================
+ Hits         1045     1082      +37     
- Misses         55       66      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpo dpo merged commit 27e9a34 into JuliaSmoothOptimizers:main Apr 9, 2025
52 of 55 checks passed
@dpo
Copy link
Member

dpo commented Apr 9, 2025

Thank you!

@MaxenceGollier MaxenceGollier deleted the inverseLSR1_doc branch April 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants