Skip to content

fix normest not working on rectangular matrices #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

njericha
Copy link
Contributor

See #362

@dpo
Copy link
Member

dpo commented Jan 31, 2025

Thank you. It looks like normest was only tested for square matrices. Would you mind adding a unit test for rectangular matrices?

@dpo
Copy link
Member

dpo commented Apr 10, 2025

Bump.

@njericha
Copy link
Contributor Author

Bump.

Thanks for the reminder. I've just added a few tests for rectangular matrices.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (32dbc5e) to head (1773afb).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   95.00%   94.26%   -0.74%     
==========================================
  Files          17       20       +3     
  Lines        1100     1151      +51     
==========================================
+ Hits         1045     1085      +40     
- Misses         55       66      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dpo dpo merged commit 120d496 into JuliaSmoothOptimizers:main Apr 11, 2025
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants