Skip to content

CompatHelper: bump compat for ADNLPModels to 0.8, (keep existing compat) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2024

This pull request changes the compat entry for the ADNLPModels package from 0.4, 0.5, 0.6, 0.7 to 0.4, 0.5, 0.6, 0.7, 0.8.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-06-06-00-23-28-949-03896997890 branch from 272d732 to 4e636ec Compare June 6, 2024 00:23
@tmigot tmigot closed this Jun 6, 2024
@tmigot tmigot reopened this Jun 6, 2024
@tmigot
Copy link
Member

tmigot commented Jun 6, 2024

@abelsiqueira am I correct to assume that the benchmark fails because the PR comes from outside the organization? For some reason, the logs are not loading.

@tmigot tmigot merged commit e55f774 into main Jun 13, 2024
14 of 15 checks passed
@tmigot tmigot deleted the compathelper/new_version/2024-06-06-00-23-28-949-03896997890 branch June 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant