Skip to content

Add function reinit_task #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

efaulhaber
Copy link
Contributor

@efaulhaber efaulhaber commented May 21, 2025

JuliaSIMD/Polyester.jl#154 caused Trixi.jl CI to freeze sometimes.
I don't have a MWE for this, but the solution is to only re-initialize failed tasks.

To summarize the previous developments:

@efaulhaber
Copy link
Contributor Author

CC @oscardssmith

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

@oscardssmith
Copy link
Member

rerunning ci

@oscardssmith oscardssmith reopened this May 21, 2025
@efaulhaber
Copy link
Contributor Author

Looks like everything is passing except nightly macOS.

@oscardssmith
Copy link
Member

The segfault is somewhat concerning (as is the use of deprecated LLVM code). We really should replace the hand-rolled LLVM with Julia equivalents since LLVM has absolutely no stability.

@efaulhaber
Copy link
Contributor Author

I had several segfaults when I ran the tests locally, all from the "ThreadingUtilities" testset. Which deprecated LLVM code are you talking about?

@oscardssmith
Copy link
Member

If you look at the CI logs, there's a bunch of

WARNING: llvmcall with integer pointers is deprecated.
Use actual pointers instead, replacing i32 or i64 with i8* or ptr
in _all(Any, Any, Base.Colon) at anyall.jl
WARNING: llvmcall with integer pointers is deprecated.
Use actual pointers instead, replacing i32 or i64 with i8* or ptr
in test_copy(Any, Any) at /Users/runner/work/ThreadingUtilities.jl/ThreadingUtilities.jl/test/threadingutilities.jl

but really the whole https://github.com/JuliaSIMD/ThreadingUtilities.jl/blob/main/src/atomics.jl should be written in Julia rather than LLVM.

@oscardssmith
Copy link
Member

I wonder if the problem is

(specifically the fact that there doesn't appear to be anything here to ensure alignment)

@efaulhaber
Copy link
Contributor Author

efaulhaber commented May 23, 2025

This stuff is unfortunately way out of the scope of my expertise.

@ranocha
Copy link
Member

ranocha commented May 23, 2025

Since this PR doesn't change the code with deprecated LLVM features, I would prefer merging it, as it represents a strict improvement and is required to fix some issues with Polyester.jl.
The other issues should be handled in another PR.

@oscardssmith oscardssmith merged commit 922c747 into JuliaSIMD:main May 23, 2025
65 of 68 checks passed
@efaulhaber efaulhaber deleted the reinit-task branch May 23, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants