change delete return type #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+6
to
+7
| @deprecate addBlob!(store::AbstractBlobStore, blobId::UUID, data, ::String) addBlob!(store, blobId, data) | ||
| @deprecate addBlob!(store::AbstractBlobStore{T}, data::T, ::String) where {T} addBlob!(store, uuid4(), data) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @deprecate addBlob!(store::AbstractBlobStore, blobId::UUID, data, ::String) addBlob!(store, blobId, data) | |
| @deprecate addBlob!(store::AbstractBlobStore{T}, data::T, ::String) where {T} addBlob!(store, uuid4(), data) | |
| @deprecate addBlob!(store::AbstractBlobStore, blobId::UUID, data, ::String) addBlob!( | |
| store, | |
| blobId, | |
| data, | |
| ) | |
| @deprecate addBlob!(store::AbstractBlobStore{T}, data::T, ::String) where {T} addBlob!( | |
| store, | |
| uuid4(), | |
| data, | |
| ) |
| @@ -62,8 +70,3 @@ DFGSummary(args) = error("DFGSummary is deprecated") | |||
|
|
|||
| @deprecate lsfWho(dfg::AbstractDFG, type::Symbol) lsf(dfg, getfield(Main, type)) | |||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @@ -213,8 +213,15 @@ function updateGraphMetadata!(dfg::AbstractDFG, pair::Pair{Symbol, String}) | |||
| return push!(dfg.graphMetadata, pair) | |||
| end | |||
|
|
|||
| deleteAgentMetadata!(dfg::AbstractDFG, key::Symbol) = pop!(dfg.agent.metadata, key) | |||
| deleteGraphMetadata!(dfg::AbstractDFG, key::Symbol) = pop!(dfg.graphMetadata, key) | |||
| function deleteAgentMetadata!(dfg::AbstractDFG, key::Symbol) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function deleteAgentMetadata!(dfg::AbstractDFG, key::Symbol) | |
| function deleteAgentMetadata!(dfg::AbstractDFG, key::Symbol) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1134 +/- ##
===========================================
+ Coverage 75.49% 75.57% +0.08%
===========================================
Files 28 28
Lines 2387 2391 +4
===========================================
+ Hits 1802 1807 +5
+ Misses 585 584 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteshould now return number of nodes deleted