Skip to content

defFactorType macro #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

defFactorType macro #1077

merged 5 commits into from
Jun 12, 2025

Conversation

Affie
Copy link
Member

@Affie Affie commented Jun 18, 2024

  • Need to still sort out how pack/unpack/convert can work.
    • Design decision is to work with pack / unpack and not convert
  • Rename to defFactorType
  • upstream PackedSamplableBelief

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (05ad44d) to head (72f7c39).
Report is 3 commits behind head on refac/factor.

Files with missing lines Patch % Lines
src/services/DFGFactor.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           refac/factor    #1077      +/-   ##
================================================
- Coverage         75.32%   75.19%   -0.13%     
================================================
  Files                28       28              
  Lines              2399     2403       +4     
================================================
  Hits               1807     1807              
- Misses              592      596       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Affie and others added 5 commits June 12, 2025 12:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Affie Affie force-pushed the 24Q2/enh/defFactormacro branch from 0fc5317 to 72f7c39 Compare June 12, 2025 10:38
@Affie Affie changed the base branch from develop to refac/factor June 12, 2025 10:38
@Affie Affie marked this pull request as ready for review June 12, 2025 10:40
@Affie
Copy link
Member Author

Affie commented Jun 12, 2025

Merging to refactor factors branch

@Affie Affie merged commit 3d6c96d into refac/factor Jun 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant