-
-
Notifications
You must be signed in to change notification settings - Fork 365
Add unit
axis attribute, for Plots v1
#5098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CI is failing on this one. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5098 +/- ##
==========================================
+ Coverage 89.77% 89.80% +0.03%
==========================================
Files 40 40
Lines 8780 8867 +87
==========================================
+ Hits 7882 7963 +81
- Misses 898 904 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR isn't quite ready yet, because I think it deserves a few more tests for the UnitfulExt before merging, plus some additions to the docs. But @t-bltg the CI failures seem to be either 1) a resurface of a PlotlyJS>Blink>Electron issue #5075, which is randomly hitting only some of the Ubuntu test cases or 2) something to do with the 1.12 prerelease |
Ignore those (they are development aids), we focus on julia |
Description
Essentially identical to #5095 , but made against the
master
branch so that I'm not waiting for Plots v2--folder structures are different enough that it made sense to open as a separate PR.@gustaphe and I discussed some in #5095; it would be helpful to get feedback from @t-bltg or @BeastyBlacksmith or someone else who is not as focused on Unitful usage.
A lot of the noise in the diff is a result of switching to
Plots.get_guide(axis)
instead ofaxis[:guide]
, because that new function allows us to more elegantly handle differing unit formats in the guide strings; in any case where the axis has no units, the result ofget_guide(axis)
isaxis[:guide]
so not a big change in behavior.Other changes involve moving some of the machinery out of the UnitfulExt so that it is accessible within Plots for axis handling.
Attribution
Things to consider