Skip to content

clear broken examples #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

clear broken examples #5076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions PlotsBase/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,7 @@ is_ci() || @eval using Gtk # see JuliaPlots/VisualRegressionTests.jl/issues/30

ref_name(i) = "ref" * lpad(i, 3, '0')

const broken_examples = if Sys.isapple()
[50] # FIXME: https://github.com/jheinen/GR.jl/issues/550
else
[]
end
const BROKEN_EXAMPLES = []

for name ∈ (
"misc",
Expand Down
2 changes: 1 addition & 1 deletion PlotsBase/test/test_backends.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ is_pkgeval() || @testset "Backends" begin
@test filesize(fn) > 1_000
end
(Sys.islinux() && is_latest("release")) && for be ∈ TEST_BACKENDS
skip = vcat(PlotsBase._backend_skips[be], broken_examples)
skip = vcat(PlotsBase._backend_skips[be], BROKEN_EXAMPLES)
PlotsBase.test_examples(be; skip, callback, disp = is_ci(), strict = true) # `ci` display for coverage
closeall()
end
Expand Down
2 changes: 1 addition & 1 deletion PlotsBase/test/test_reference.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ end
:gr,
tol = PLOTSBASE_IMG_TOL,
skip = vcat(PlotsBase._backend_skips[:gr]),
broken = broken_examples,
broken = BROKEN_EXAMPLES,
)
end
end
Loading