Skip to content

interpolate scratch_dir to avoid precompilation failure in 1.12 #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

lmiq
Copy link
Contributor

@lmiq lmiq commented Apr 15, 2025

Description

Interpolating the scratch_dir variable in the precompilation directive solves the precompilation failure observed in v1.12-beta1.

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@lmiq
Copy link
Contributor Author

lmiq commented Apr 15, 2025

I think it would be nice, if this is a good solution, to make a 1.40.13 release with this as soon as possible, because otherwise CI runs will fail for all packages in Julia 1.12 pre-releases that depend on Plots.jl (on extensions, for example).

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (fa65e7d) to head (ef43f16).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5072      +/-   ##
==========================================
- Coverage   89.77%   89.38%   -0.39%     
==========================================
  Files          40       40              
  Lines        8780     8452     -328     
==========================================
- Hits         7882     7555     -327     
+ Misses        898      897       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BeastyBlacksmith
Copy link
Member

Thanks! Would be nice, if you also could port that to the v2 branch.

@BeastyBlacksmith BeastyBlacksmith merged commit 7944c4c into JuliaPlots:master Apr 17, 2025
10 of 19 checks passed
lmiq added a commit to lmiq/Plots.jl that referenced this pull request Apr 17, 2025
@lmiq lmiq mentioned this pull request Apr 17, 2025
7 tasks
BeastyBlacksmith pushed a commit that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants