GR: Fix zscale support in surface plots #5063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `zscale` was being set to a Bool value (the result of the set membership check). This caused a crash when querying the `gr_z_log_scales` tuple on the next line, because that array is indexed by symbols like :log10. Given that the lines above assign the actual symbols to `xscale` and `yscale`, it seems likely that `zscale` should behave the same. Fixes: JuliaPlots#5062
|
The MWE from the linked issue now seems to be working. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5063 +/- ##
==========================================
- Coverage 89.77% 89.42% -0.35%
==========================================
Files 40 40
Lines 8780 8453 -327
==========================================
- Hits 7882 7559 -323
+ Misses 898 894 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice catch! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
zscalewas being set to a Bool value (the result of the set membership check). This caused a crash when querying thegr_z_log_scalestuple on the next line, because that array is indexed by symbols like :log10.Given that the lines above assign the actual symbols to
xscaleandyscale, it seems likely thatzscaleshould behave the same.Fixes: #5062
Attribution
Things to consider