Skip to content

Correct connector line in lens! for non-linear scales #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

BeastyBlacksmith
Copy link
Member

Description

Fix #4975

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@BeastyBlacksmith BeastyBlacksmith changed the base branch from v2 to master March 14, 2025 13:46
@BeastyBlacksmith BeastyBlacksmith merged commit bc1fcd4 into JuliaPlots:master Mar 18, 2025
11 of 17 checks passed
@BeastyBlacksmith BeastyBlacksmith deleted the bbs/lensline branch March 18, 2025 08:25
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (fa65e7d) to head (6bb4873).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5055      +/-   ##
==========================================
- Coverage   89.77%   89.03%   -0.74%     
==========================================
  Files          40       40              
  Lines        8780     8252     -528     
==========================================
- Hits         7882     7347     -535     
- Misses        898      905       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Function lens! still has a bug with its connector line
1 participant