Skip to content

Get PETSc loading again with Julia 1.11 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Get PETSc loading again with Julia 1.11 #194

merged 5 commits into from
Oct 14, 2024

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Oct 14, 2024

The purpose of this PR is to get PETSc loading again, and to pass as many tests as possible.

The extent of commented out tests shows the damage that needs fixing.

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 14, 2024

@boriskaus I think with this, one can at least load the package without errors and warnings. I suggest we merge this into master, and then incrementally get all the commented out tests working again (some of the tests and MPI stuff needs updating).

This also hopefully gets it to a point where others interested can try it out and new contributors may be able to step up.

@boriskaus
Copy link
Collaborator

thanks, does this autowrap the library?

@ViralBShah
Copy link
Member Author

No that is a separate PR that is open. This is just doing the minimal to get the existing package loading. Note various tests are commented out.

@boriskaus
Copy link
Collaborator

boriskaus commented Oct 14, 2024

ok, I'm fine merging this (I guess the tests should pass though, or we only support the lts)

Note that this branch https://github.com/JuliaParallel/PETSc.jl/tree/jek/dmstag has autowrap functions that can perhaps be used again

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 14, 2024

I have a few other tests I am enabling. The large majority of the tests are now passing. Tests that are commented out are now marked as FIXME so that they can be chased down and enabled.

Tests that need to be fixed are marked as FIXME
@ViralBShah
Copy link
Member Author

Now only a small number of tests are commented out. I don't know what is happening with Windows, but that seems like some kind of MPI issue. I'll open a separate issue for that.

The Documentation has lots of duplicate function issues, but I am not sure how to fix them all. Not an issue for now.

@ViralBShah ViralBShah merged commit 858ae15 into main Oct 14, 2024
0 of 6 checks passed
@ViralBShah ViralBShah deleted the vs/update branch October 14, 2024 18:33
@ViralBShah
Copy link
Member Author

ok, I'm fine merging this (I guess the tests should pass though, or we only support the lts)

Note that this branch https://github.com/JuliaParallel/PETSc.jl/tree/jek/dmstag has autowrap functions that can perhaps be used again

I opened that closed PR again to leave it as a reminder. I am not a user of PETSc really, so this may be more work than I can help with - but I'll give it a shot.

For now, the package is working, and it will be nice to reinstate all the tests and get Windows and docs working again too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants