-
Notifications
You must be signed in to change notification settings - Fork 39
Get PETSc loading again with Julia 1.11 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
using PETSc works now. Tests fail
@boriskaus I think with this, one can at least load the package without errors and warnings. I suggest we merge this into master, and then incrementally get all the commented out tests working again (some of the tests and MPI stuff needs updating). This also hopefully gets it to a point where others interested can try it out and new contributors may be able to step up. |
thanks, does this autowrap the library? |
No that is a separate PR that is open. This is just doing the minimal to get the existing package loading. Note various tests are commented out. |
ok, I'm fine merging this (I guess the tests should pass though, or we only support the lts) Note that this branch https://github.com/JuliaParallel/PETSc.jl/tree/jek/dmstag has autowrap functions that can perhaps be used again |
I have a few other tests I am enabling. The large majority of the tests are now passing. Tests that are commented out are now marked as FIXME so that they can be chased down and enabled. |
Tests that need to be fixed are marked as FIXME
Now only a small number of tests are commented out. I don't know what is happening with Windows, but that seems like some kind of MPI issue. I'll open a separate issue for that. The Documentation has lots of duplicate function issues, but I am not sure how to fix them all. Not an issue for now. |
I opened that closed PR again to leave it as a reminder. I am not a user of PETSc really, so this may be more work than I can help with - but I'll give it a shot. For now, the package is working, and it will be nice to reinstate all the tests and get Windows and docs working again too. |
The purpose of this PR is to get PETSc loading again, and to pass as many tests as possible.
The extent of commented out tests shows the damage that needs fixing.