Skip to content

Catch exception thrown from sleep() in the Distributed watcher #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

JamesWrigley
Copy link
Collaborator

Also fixed the changelog in 3bb5e66.

@JamesWrigley JamesWrigley self-assigned this Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (b03db8e) to head (91077f5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   87.83%   87.99%   +0.16%     
==========================================
  Files          11       11              
  Lines        2063     2066       +3     
==========================================
+ Hits         1812     1818       +6     
+ Misses        251      248       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpsamaroo
Copy link
Member

What kind of errors did you get from sleep, and under what conditions?

@JamesWrigley
Copy link
Collaborator Author

For me it happens sporadically when exiting the REPL with Ctrl + D:

Unhandled Task ERROR: EOFError: read end of file                                                                                                                                                                                               
Stacktrace:                                                                                                                                                                                                                                    
 [1] wait                                                                                                                                                                                                                                      
   @ ./asyncevent.jl:162 [inlined]                                                                                                                                                                                                             
 [2] sleep
   @ ./asyncevent.jl:272 [inlined]
 [3] (::DistributedNext.var"#287#288")()
   @ DistributedNext ~/git/Distributed.jl/src/DistributedNext.jl:145

There was a related Julia issue for this somewhere... I haven't been able to find a consistent reproducer.

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Otherwise the exception would be printed when the process exits.
The watcher entry was accidentally added under the v1 changelog.
@JamesWrigley JamesWrigley merged commit 09533a9 into master Dec 9, 2024
14 checks passed
@JamesWrigley JamesWrigley deleted the close-watcher branch December 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants