Skip to content

Add check_flatness keyword to HZ and format #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Mar 26, 2025

See #174 (comment)

I'm not sure the check does what it's intended to do, so I'm turning it off and giving the possibility of turning it back on.

@pkofod
Copy link
Member Author

pkofod commented Mar 26, 2025

I should have not done the format in this pr, but... I just add a keyword and a test. That said, of course the tests do not pass on CI 😵

@pkofod
Copy link
Member Author

pkofod commented Mar 26, 2025

I should have not done the format in this pr, but... I just add a keyword and a test. That said, of course the tests do not pass on CI 😵

i see, it also fails when in a test set locally but not when run by hand 👍 what a gift that keeps on giving :)

@pkofod
Copy link
Member Author

pkofod commented Mar 26, 2025

I should have not done the format in this pr, but... I just add a keyword and a test. That said, of course the tests do not pass on CI 😵

i see, it also fails when in a test set locally but not when run by hand 👍 what a gift that keeps on giving :)

nevermind, just seems like issues.jl was not loaded and the same test had already been added as broken somewhere else

@pkofod
Copy link
Member Author

pkofod commented Mar 26, 2025

This is just a quick'n'dirty "solution". #180 is a re-implementation as mine in NLSolvers.jl and I want to compare them later, but I don't think the flatness check is currently correct so I think we should turn it off by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant