Skip to content

Integrate with DofManager from GeomOpt.jl #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 12, 2025
Merged

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Jan 1, 2025

Closes #4, superseeds #8.

@cortner A first version, which seems to work and produce the right results. Convergence is still pretty slow, though.

  • Tests for DofManager
  • Rethink the integration if this can be done better
  • Use Voigt convention to track the 6 degrees of freedom in the lattice deformation matrix.
  • Make the mapping of (position, lattice vectors) to degrees of freedom more flexible, such that custom constraints or different ways of parametrising the cell could be easily tried ... maybe only after this PR.

@mfherbst mfherbst mentioned this pull request Jan 1, 2025
@mfherbst mfherbst force-pushed the integrate_dofmanager branch from aad694e to a01338f Compare January 1, 2025 17:30
@mfherbst
Copy link
Member Author

I will merge for now and refactor when dealing with #26.

@mfherbst mfherbst marked this pull request as ready for review June 12, 2025 06:23
@mfherbst mfherbst merged commit 8a01158 into main Jun 12, 2025
5 checks passed
@mfherbst mfherbst deleted the integrate_dofmanager branch June 12, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell Shape Optimization
1 participant