Skip to content

Update of interface towards AtomsCalculator 0.2 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 9, 2024
Merged

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Jul 31, 2024

Fixes #5, fixes #9, fixes #10

Things I still want to do here:

  • Run examples as part of test suite or add them to the docs (where there are run during docs generation)
  • More testing of the examples
  • Check the results struct returned by minimise_energy! is reasonable.
  • Test if other Optimisation.jl solvers beyond Optim can actually be easily employed and have an example of that.

@mfherbst mfherbst marked this pull request as ready for review August 3, 2024 18:53
@mfherbst
Copy link
Member Author

mfherbst commented Aug 6, 2024

@cortner Let me know what you think about this once you get a minute.

It might not solve all the things you had in mind with your three issues, but I hope it gets us considerably closer.

@cortner
Copy link
Member

cortner commented Aug 8, 2024

I did a relatively quick skim. The overall structure looks great. Since this is early days and few (any?) users I think it's ok to merge without in-depth review.

I will try to help with next steps such as integrating the DOF manager, masks, the lie-cell dofs etc.

@mfherbst mfherbst merged commit acd31af into main Aug 9, 2024
3 checks passed
@mfherbst mfherbst deleted the upinterface branch August 9, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide good defaults Optimization doesn't seem to update the system Loosen Compat Requirement on EmpiricalPotentials
2 participants