-
Notifications
You must be signed in to change notification settings - Fork 0
Update of interface towards AtomsCalculator 0.2 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cortner Let me know what you think about this once you get a minute. It might not solve all the things you had in mind with your three issues, but I hope it gets us considerably closer. |
I did a relatively quick skim. The overall structure looks great. Since this is early days and few (any?) users I think it's ok to merge without in-depth review. I will try to help with next steps such as integrating the DOF manager, masks, the lie-cell dofs etc. |
Fixes #5, fixes #9, fixes #10
Things I still want to do here:
results
struct returned byminimise_energy!
is reasonable.