Some fixes for Julia 1.6 nightly #231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 70 70
Lines 4324 4324
=======================================
Hits 4129 4129
Misses 195 195 Continue to review full report at Codecov.
|
| @test sprint(show, "text/plain", x) == """ | ||
| $(sprint(show, SVDMPoint{Matrix{Float64}, Vector{Float64}, Matrix{Float64}})) | ||
| U factor: | ||
| 3×2 $(sprint(show, Matrix{Float64})): |
There was a problem hiding this comment.
You could also use the print of x.U for the whole block lines 15--18?
There was a problem hiding this comment.
I don't how to print x.U to get the correct spacing 🙁 .
There was a problem hiding this comment.
Ah, I see, because we add an indent (1 or 2 spaces?), see
Manifolds.jl/test/vector_bundle.jl
Line 121 in 67ee0f1
on a place where I tricked something like that, too.
There was a problem hiding this comment.
I think we can do that in another PR.
|
Do you have an idea why there are now so many ambiguities since 1.6? |
There were some changes about ambiguity detection, for example here: JuliaLang/julia#37616 . I don't understand what exactly was changed though. |
Let's try making tests pass on Julia 1.6 nightly. For now I'm ignoring the issue about ambiguities.