-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Expand JULIA_CPU_TARGET docs #58968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Expand JULIA_CPU_TARGET docs #58968
Conversation
8d7b16f
to
67fcbfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding of https://docs.julialang.org/en/v1/devdocs/sysimg/#Specifying-multiple-system-image-targets is that clone_all
should always be used for the second target, and base(1)
for the following ones (if the ISA is strictly larger than the second one). Also, @gbaraldi mentioned on Slack that -xsaveopt
and -rdrnd
might be needed for the x86_64 targets to workaround some unspecified bugs, but I don't know more than what I'm reporting.
# For heterogeneous environments, use generic to ensure broad compatibility | ||
export JULIA_CPU_TARGET="generic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should recommend JULIA_CPU_TARGET="generic"
for heterogeneous systems, stuff like JULIA_CPU_TARGET="generic;haswell"
is better and provides the safe fallback of generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we recommend the one we actually use to ship Julia?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True but that's different across platforms. I guess we could link to the build code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we copy it to docs it's likely to get outdated because that's in a different repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have an option that copies the value that the sysimage was built with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's proposed here #58970
Part of #55157
#55157 also talks about checks for less specific pkgimage vs. sysimage cpu targets not being in place. That's not addressed here.