implement SubArray reindexing without using @generated
#58800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tuple specialization for indexing with UnitRanges (with up to 10 values) is highly optimized and type stable for statically known values like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuple specialization for indexing with UnitRanges is highly optimized, type stable, and constant foldable for statically known values like these.
Seems like a very good thing to just lean on that. It's how I would've written this in the first place had that optimized method existed when I wrote it. It's much more readable and — I imagine — it should be quite a bit friendlier to the compiler. The only time you should see a performance difference here is when you have a SubArray with 11 or more indices and one of those indices is 3-dimensional or more.