Specialize iterate
for AbstractOneTo
#58677
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #58635, which produces a similar performance improvement. This is more general, as the improvement would apply to arbitrary iterators that use
AbstractOneTo
axes, and not just toAbstractArray
s. The idea is thatiterate(r::OneTo, i::Integer)
now returnsnothing
ifi > last(r)
, instead of returning an out-of-bound value. This ensures that iterating over aOneTo
always produces valid indices.