-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Windows shell support in REPL #58526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MilesCranmer
wants to merge
14
commits into
JuliaLang:master
Choose a base branch
from
MilesCranmer:windows-shell-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Windows shell support in REPL #58526
MilesCranmer
wants to merge
14
commits into
JuliaLang:master
from
MilesCranmer:windows-shell-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace regex with explicit replace. Remove @static macro and use `Sys.iswindows()` instead Co-authored-by: Jakob Nybo Nissen <jakobnybonissen@gmail.com>
This was referenced May 25, 2025
This was referenced May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of @stevengj's #31490 on top of the cleaned-up
repl_cmd
in #58525. It should only be merged after that PR.This PR also extends #31490 to handle
cd
for the various windows shells, which has become simpler and more maintainable after the cleanup. Note that these functions do not allow passing flags at the moment; however, it is much easier for a power user to extend this behaviour if they so desire in their startup.jl.The specific diff of this PR is as follows:
For example, the line
is equivalent to saying "if we are on Windows (true) and using powershell, then a 'cd' command should be performed if the first word is either Set-Location, cd, sl, or chdir."
You can try this PR out in your local julia by pasting the following code into your startup.jl: https://gist.github.com/MilesCranmer/0b530cf4602905d548acdfb3bb54ded0